Re: [COMMITTERS] pgsql: Disable BLOB test in pg_dump TAP tests

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Disable BLOB test in pg_dump TAP tests
Date: 2016-05-08 17:02:11
Message-ID: 20160508170211.GC10850@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

* Andrew Dunstan (andrew(at)dunslane(dot)net) wrote:
> TL;DR version: Msys provides a virtualized Unix-like file system
> that is visible to its programs that you use to build, but invisible
> to the programs you build since they are going to run without any
> knowledge of the build environment. So you can't just put $tmpdir
> from an Msys-aware program into a psql script and expect it to work.
> It won't. Maybe we need to provide a function in our test library to
> convert virtual paths to real paths. (For Unix it would be a NOOP).

I'm pretty confident that I can work around this for the specific test
that was having trouble, but it seems like it'd be nice to have a way to
refer to the actual data and temp directories from psql and friends when
they're run under the TAP test system.

Ideally, there'd be a way to make it transparent, so we don't have to
write the tests to handle this case explicitly, though I'm not sure if
there's an easy way to do that.

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-05-08 20:36:29 pgsql: Docs: create some user-facing documentation about index-only sca
Previous Message Stephen Frost 2016-05-08 16:58:26 pgsql: Wording quibbles regarding initdb username

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2016-05-08 17:40:56 Re: minor message improvement
Previous Message Stephen Frost 2016-05-08 16:59:05 Re: Re: "pg_xxx" role name restriction not applied to bootstrap superuser?