Re: pgsql: Add TAP tests for pg_dump

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add TAP tests for pg_dump
Date: 2016-05-06 19:11:53
Message-ID: 20160506191153.GW10850@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

* Peter Eisentraut (peter(dot)eisentraut(at)2ndquadrant(dot)com) wrote:
> On 5/6/16 2:06 PM, Stephen Frost wrote:
> >Add TAP tests for pg_dump
>
> I'd be the first to welcome this, but what happened to feature freeze?

These are just new tests..? I assumed that would be welcome during post
feature-freeze, and certainly no one raised any concerns about adding
these tests during the discussion prior to my commiting them.

We back-patch new tests from time to time too, when they're associated
with bug fixes, so I'm pretty confused why TAP tests would be an issue
to add on HEAD post feature-freeze.

If the consensus is that we shouldn't add new tests during feature
freeze, I'll revert the patch that added them and add them later, but,
for my 2c at least, I think we should be happy to add these even after
feature freeze.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-05-06 19:14:37 Re: pgsql: Add TAP tests for pg_dump
Previous Message Peter Eisentraut 2016-05-06 19:07:51 Re: pgsql: Add TAP tests for pg_dump

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-05-06 19:14:37 Re: pgsql: Add TAP tests for pg_dump
Previous Message Peter Eisentraut 2016-05-06 19:07:51 Re: pgsql: Add TAP tests for pg_dump