| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump dump catalog ACLs |
| Date: | 2016-05-04 21:28:24 |
| Message-ID: | 20160504212824.GI10850@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah, all,
* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> The test suite is now covering 57% of pg_dump.c. I was hoping to get
> that number higher, but time marches on and more tests can certainly be
> added later.
I've managed to get the test suite up another 10%, to 67% of pg_dump.c.
Still quite a bit to do, but it turned up a bug in CREATE TRANSFORM,
which lead to Peter discovering a similar issue in CREATE CAST, so I'd
say it's certainly showing that it's worthwhile to have.
Updated patch-set which includes the additional tests and also a patch
to avoid LOCK'ing tables when we don't need to, as discussed with Tom
and Robert on another thread.
Thanks!
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump_improvements_v3.patch | text/x-diff | 93.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2016-05-04 21:31:17 | Re: pg_dump broken for non-super user |
| Previous Message | Tomas Vondra | 2016-05-04 21:26:59 | Re: pg9.6 segfault using simple query (related to use fk for join estimates) |