Re: BUG #14109: pg_rewind fails to update target control file in one scenario

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: John Lumby <johnlumby(at)hotmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14109: pg_rewind fails to update target control file in one scenario
Date: 2016-04-29 11:42:16
Message-ID: 20160429114216.GA126732@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier wrote:
> On Thu, Apr 28, 2016 at 8:28 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:

> > Sounds to me like it should be enough to document (in pg_rewind's page)
> > that activating a slot prior to the promotion. Maybe we could have
> > "pg_ctl promote" have an option to create a slot, to make this simpler?
>
> That would be actually creating a slot before the last common
> checkpoint before promotion, which is a bit more tricky to evaluate.
> With luck, perhaps both of them would be on the same segment, but
> there is no way to be sure about that... It seems to me that what we
> are looking for here is a way to tell through
> pg_create_physical_replication_slot to reserve WAL from a position
> that caller has decided.

Well, that sounds like just a SMOP, doesn't it?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2016-04-29 12:08:55 Re: BUG #14109: pg_rewind fails to update target control file in one scenario
Previous Message Michael Paquier 2016-04-29 11:25:55 Re: BUG #14109: pg_rewind fails to update target control file in one scenario