Re: BUG #14109: pg_rewind fails to update target control file in one scenario

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: John Lumby <johnlumby(at)hotmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14109: pg_rewind fails to update target control file in one scenario
Date: 2016-04-28 11:28:50
Message-ID: 20160428112850.GA71376@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier wrote:
> On Wed, Apr 27, 2016 at 9:47 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:

> > Replication slots are perfectly able to retain WAL segments from a
> > prior timeline, so I am not sure that this would be much a gain.
>
> Or to put in in other words, a slot that activates automatically
> itself at promotion to retain WAL from the previous timeline would be
> interesting for pg_rewind, but the use case we have here is only
> pg_rewind. so it seems a bit narrow to bother modifying the core core
> to add this support in the replication slot code. And this can be
> solved lightly with an archive. Thoughts from others are welcome.

Sounds to me like it should be enough to document (in pg_rewind's page)
that activating a slot prior to the promotion. Maybe we could have
"pg_ctl promote" have an option to create a slot, to make this simpler?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message tushar 2016-04-28 12:07:45 alter table .. reset not throwing an error if storage_parameter name is wrong
Previous Message Georg Kahest 2016-04-28 10:11:31 Re: BUG #14112: sorting v and w is broken with et_EE locate