| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Kevin Grittner <kgrittn(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thom Brown <thom(at)linux(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Kevin Grittner <kgrittn(at)ymail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: snapshot too old, configured by time |
| Date: | 2016-04-19 16:02:20 |
| Message-ID: | 20160419160220.GA705298@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> On 2016-04-19 12:03:22 -0300, Alvaro Herrera wrote:
> > > Since this change to BufferGetPage() has caused severe back-patch
> > > pain for at least two committers so far, I will revert that (very
> > > recent) change to this patch later today unless I hear an
> > > objections.
> >
> > I vote for back-patching a no-op change instead, as discussed elsewhere.
>
> What about Tom's argument that that'd be problematic for external code?
Kevin offered to code it in a way that maintains ABI and API
compatibility with some trickery.
Robert Haas wrote:
> That wouldn't have fixed my problem, which involved rebasing a patch.
True. I note that it's possible to munge a patch mechanically to sort
out this situation.
> I really think it's also a bad precedent to back-patch things into
> older branches that are not themselves bug fixes. Users count on us
> not to destabilize older branches, and that means being minimalist
> about what we put into them.
Well, this wouldn't change the inner working of the code at all, only
how it looks, so it wouldn't affect users. I grant that it would affect
developers of forks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2016-04-19 16:48:01 | Re: VS 2015 support in src/tools/msvc |
| Previous Message | Stas Kelvich | 2016-04-19 15:46:05 | Re: Parser extensions (maybe for 10?) |