| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner. |
| Date: | 2016-04-17 17:07:36 |
| Message-ID: | 20160417170736.hbly4drjqdhnb5rm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2016-04-17 12:01:48 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Allow Pin/UnpinBuffer to operate in a lockfree manner.
>
> Now that I've had some occasion to look around in bufmgr.c, I am very
> unhappy that there are still boatloads of comments talking about a buffer
> header's spinlock, when there is in fact no spinlock anymore.
That's actually intentional. Alexander had changed those, and it made
the patch a good bit harder to read because there's so many references.
As the new thing is still a spinlock, just not a s_lock.[ch] style on, I
don't see changing all that to be a significant benefit.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-17 17:20:29 | Re: pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner. |
| Previous Message | Andres Freund | 2016-04-17 17:04:37 | Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-17 17:20:29 | Re: pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner. |
| Previous Message | Andres Freund | 2016-04-17 17:04:37 | Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |