| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, jeff(dot)janes(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: multivariate statistics v14 |
| Date: | 2016-03-26 19:09:33 |
| Message-ID: | 20160326190933.GA725919@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra wrote:
> There are a few places where I reverted the pgindent formatting, because it
> seemed a bit too weird - the first one are the lists of function prototypes
> in common.h/mvstat.h, the second one are function calls to
> _greedy/_exhaustive methods.
Function prototypes being weird is something that we've learned to
accept. There's no point in undoing pgindent decisions there, because
the next run will re-apply them anyway. Best not to fight it.
What you should definitely look into fixing is the formatting of
comments, if the result is too horrible. You can prevent it from
messing those by adding dashes /*----- at the beginning of the comment.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2016-03-26 20:21:06 | Typo in comment |
| Previous Message | Regina Obe | 2016-03-26 18:30:16 | Re: Can we amend gitignore so git postgresql works with git on windows using Msys/Mingw64 |