| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Rationalizing code-sharing among src/bin/ directories |
| Date: | 2016-03-23 18:13:59 |
| Message-ID: | 20160323181359.GA613718@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Note: the reason for a new subdirectory, rather than putting this
> stuff into src/common/, is that src/common/ is meant for code that's
> shared between frontend and backend, which this stuff is not. Also,
> many of these files depend on libpq which seems like an inappropriate
> dependency for src/common.
Actually you could just list them in OBJS_FRONTEND in src/common. That
way they're not built for the server at all; no need for a new subdir.
The libpq dependency argument AFAICS only applies to the ones in
src/bin/psql. Perhaps we could have feutils with those only, and move
the other files to src/common.
I'm unclear on the #ifndef PGSCRIPTS thingy in mbprint.c. Perhaps it's
no longer needed?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-03-23 18:14:35 | Re: Re: Missing rows with index scan when collation is not "C" (PostgreSQL 9.5) |
| Previous Message | Tom Lane | 2016-03-23 18:13:56 | Re: Re: Missing rows with index scan when collation is not "C" (PostgreSQL 9.5) |