| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Minor bug affecting ON CONFLICT lock wait log messages |
| Date: | 2016-03-22 16:22:23 |
| Message-ID: | 20160322162223.GA437283@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost wrote:
> I don't think either message really fits here, unfortunately. We're not
> actually checking the uniqueness of someone else's tuple here either,
> after all, we're waiting to see what happens with their tuple because
> ours won't be unique if it goes in with that other tuple in place, if
> I'm following along correctly.
FWIW I think the translatability argument carries very little weight.
We add new messages to the catalog in minor releases every now and then.
We don't take it lightly of course, but avoiding so isn't a reason to
not fix a bug properly.
In this case, given the discussion, it seems to me that the right fix is
to create a new XLTW enum as I already mentioned, with a message
tailored to the specific case.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2016-03-22 16:27:40 | Re: Updated backup APIs for non-exclusive backups |
| Previous Message | Magnus Hagander | 2016-03-22 16:14:18 | Re: Updated backup APIs for non-exclusive backups |