Re: BUG #14033: cross-compilation to ARM fails

On Mon, Mar 21, 2016 at 12:39:21PM -0400, Tom Lane wrote:
> Daniel Golle <daniel(at)makrotopia(dot)org> writes:
> > On Mon, Mar 21, 2016 at 10:53:46AM -0400, Tom Lane wrote:
> >> Specifically, I'd like to see config.log from the second
> >> (cross-compilation) configure run.
>
> > Having a closer look it seems to fail on the first run, see
> > https://github.com/openwrt/packages/blob/master/libs/postgresql/Makefile#L85
> > for the two invocations of configure (build host is x86_64).
>
> Ah, that's something quite different from what we were assuming.
>
> AFAICS, configure is correctly detecting that it can build SSE code on
> that host as long as it uses -msse4.2, and it does show
> CFLAGS_SSE42='-msse4.2' in the "output variables" part of config.log:
>
> ...
> Not only is that missing -msse4.2, but it's missing all of the switches
> that should have been inserted from configure's version of CFLAGS, too.
> So somehow, neither CFLAGS nor CFLAGS_SSE42 are getting propagated from
> configure's decisions to the src/port make run.
>
> (pokes around...) I can replicate that command line if I do this:
>
> make CFLAGS="-I../../libpq"
>
> as that completely overrides the makefile's attempts to set CFLAGS.
> And that's what I see your project script doing, at line 119.
> Don't do that. Quite aside from breaking the intended set of CFLAGS,
> this extra include is completely useless.

In the past we needed to append that include directory for preproc/ecpg
to build stand-alone and neither me nor anyone possibly ever checked if
it was still necessary...

Well, thank you for your help and review of our package build script!
The package now builds when no longer appending the errornous include
path to CFLAGS.

Sorry for bugging you with something actually caused by the packaging.