Re: multivariate statistics v14

Hello, I returned to this.

At Sun, 13 Mar 2016 22:59:38 +0100, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in <1457906378(dot)27231(dot)10(dot)camel(at)2ndquadrant(dot)com>
> Oh, yeah. There was an extra pfree().
>
> Attached is v15 of the patch series, fixing this and also doing quite a
> few additional improvements:
>
> * added some basic examples into the SGML documentation
>
> * addressing the objectaddress omissions, as pointed out by Alvaro
>
> * support for ALTER STATISTICS ... OWNER TO / RENAME / SET SCHEMA
>
> * significant refactoring of MCV and histogram code, particularly 
>   serialization, deserialization and building
>
> * reworking the functional dependencies to support more complex 
>   dependencies, with multiple columns as 'conditions'
>
> * the reduction using functional dependencies is also significantly 
>   simplified (I decided to get rid of computing the transitive closure 
>   for now - it got too complex after the multi-condition dependencies, 
>   so I'll leave that for the future

Many trailing white spaces found.

0002

+ * Portions Copyright (c) 1996-2014, PostgreSQL Global Development Group

2014 should be 2016?

This patch defines many "magic"s for many structs, but
magic(number)s seems to be used to identify file or buffer page
in PostgreSQL. They wouldn't be needed if you don't intend to
dig out or identify the orphan memory blocks of mvstats.

+ MVDependency deps[1]; /* XXX why not a pointer? */

MVDependency seems to be a pointer type.

+ if (numcols >= MVSTATS_MAX_DIMENSIONS)
+ ereport(ERROR,
and
+ Assert((attrs->dim1 >= 2) && (attrs->dim1 <= MVSTATS_MAX_DIMENSIONS));

seem to be contradicting.

.. Sorry, time is up..

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center