From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Robbie Harwood <rharwood(at)redhat(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH v6] GSSAPI encryption support |
Date: | 2016-03-15 19:54:36 |
Message-ID: | 20160315195436.GE3127@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robbie,
* Robbie Harwood (rharwood(at)redhat(dot)com) wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> > - maj_stat = gss_accept_sec_context(
> > - &min_stat,
> > + maj_stat = gss_accept_sec_context(&min_stat,
> >
> > This is just noise.
>
> You're not wrong, though I do think it makes the code more readable by
> enforcing style and this is a "cleanup" commit. I'll take it out if it
> bothers you.
First, thanks much for working on this, I've been following along the
discussions and hope to be able to help move it to commit, once it's
ready.
Secondly, generally, speaking, we prefer that 'cleanup' type changes
(particularly whitespace-only ones) are in independent commits which are
marked as just whitespace/indentation changes. We have a number of
organizations which follow our code changes and it makes it more
difficult on them to include whitespace/indentation changes with code
changes.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-03-15 20:12:23 | Re: Choosing parallel_degree |
Previous Message | Peter Geoghegan | 2016-03-15 19:49:25 | Re: [NOVICE] WHERE clause not used when index is used |