| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Confusing with commit time usage in logical decoding |
| Date: | 2016-03-01 16:57:55 |
| Message-ID: | 20160301165755.GA356079@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Artur Zakirov wrote:
> Hello, Andres
>
> You have introduced a large replication progress tracking infrastructure
> last year. And there is a problem described at the link in the quote below.
>
> Attached patch fix this issue. Is this patch correct? I will be grateful if
> it is and if it will be committed.
AFAICS this is clearly a bug introduced in 5aa235042:
/* replay actions of all transaction + subtransactions in order */
ReorderBufferCommit(ctx->reorder, xid, buf->origptr, buf->endptr,
- parsed->xact_time);
+ commit_time, origin_id, origin_lsn);
}
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2016-03-01 17:07:24 | Re: The plan for FDW-based sharding |
| Previous Message | Anastasia Lubennikova | 2016-03-01 16:55:12 | Re: WIP: Covering + unique indexes. |