| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)heroku(dot)com>, Ants Aasma <ants(at)cybertec(dot)at> |
| Subject: | Re: xlc atomics |
| Date: | 2016-02-15 17:33:42 |
| Message-ID: | 20160215173342.GC25464@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-02-15 12:11:29 -0500, Noah Misch wrote:
> These suggested OidGenLock wasn't doing its job. I've seen similar symptoms
> around WALInsertLocks with "IBM XL C/C++ for Linux, V13.1.2 (5725-C73,
> 5765-J08)" for ppc64le. The problem is generic-xlc.h
> pg_atomic_compare_exchange_u32_impl() issuing __isync() before
> __compare_and_swap(). __isync() shall follow __compare_and_swap(); see our
> own s_lock.h, its references, and other projects' usage:
Ugh. You're right! It's about not moving code before the stwcx...
Do you want to add the new test (no objection, curious), or is that more
for testing?
Greetings,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-02-15 17:39:58 | Re: [PATCH] Code refactoring related to -fsanitize=use-after-scope |
| Previous Message | Magnus Hagander | 2016-02-15 17:32:06 | Re: New pg_upgrade data directory inside old one? |