| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Subject: | Re: Seg fault in pgbench |
| Date: | 2016-02-12 20:22:59 |
| Message-ID: | 20160212202259.GA574470@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Janes wrote:
> If I give pgbench an empty file, I get a segfault.
>
> $ touch empty.sql
> $ src/bin/pgbench/pgbench -T 60 -f empty.sql
> starting vacuum...end.
> Segmentation fault (core dumped)
I fixed this by checking whether the first command is NULL; originally
this case was handled by checking whether the command list itself was
NULL. It could also be fixed by having process_file() return NULL in
the case of an command-less file, but it seemed more churn for no actual
reason, since the case is going to be rejected by exiting the program
anyway.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-02-12 20:58:07 | Re: proposal: schema PL session variables |
| Previous Message | Jim Nasby | 2016-02-12 20:11:39 | Re: proposal: schema PL session variables |