Re: Add generate_series(date, date) and generate_series(date, date, integer)

From: David Steele <david(at)pgmasters(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add generate_series(date, date) and generate_series(date, date, integer)
Date: 2016-02-02 16:41:01
Message-ID: 20160202164101.1291.30526.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, failed

Everything looks good except for two minor issues:

1) There should be an informative comment for this struct:

+/* Corey BEGIN */
+typedef struct
+{
+ DateADT current;
+ DateADT stop;
+ int32 step;
+} generate_series_date_fctx;

2) There's an extra linefeed after the struct. Needed?

Regards,
-David

The new status of this patch is: Waiting on Author

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-02-02 17:06:50 Re: Relation extension scalability
Previous Message Robert Haas 2016-02-02 16:39:03 Re: RFC: replace pg_stat_activity.waiting with something more descriptive