Re: proposal: add 'waiting for replication' to pg_stat_activity.state

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Julian Schauder <julian(dot)schauder(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: add 'waiting for replication' to pg_stat_activity.state
Date: 2016-01-18 17:43:18
Message-ID: 20160118174318.GA81321@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund wrote:
> On December 4, 2015 9:48:55 AM GMT+01:00, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> >On 3 December 2015 at 22:58, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> >wrote:
> >
> >> On Thu, Dec 3, 2015 at 9:02 AM, Craig Ringer <craig(at)2ndquadrant(dot)com>
> >> wrote:
>
> >http://www.postgresql.org/message-id/CAA4eK1+=5Ex8-5NRr3u94=_t2p65v0kcjZ5rXddVmkx=LwAJ+w@mail.gmail.com
> >>
> >Good point. I'm not sure this shouldn't set 'waiting' anyway, though.
>
> No. Waiting corresponds to pg locks -setting it to true for other things would be even more confusing...

Robert's opinion elsewhere is relevant for this patch, and contradicts
Andres' opinion here:
http://www.postgresql.org/message-id/CA+Tgmoaj+EPoO9qobvFH18F5kJg2tAEXhQ8_-VayWHUr-ZATMw@mail.gmail.com

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Ramsey 2016-01-18 17:55:22 Re: Expanded Objects and Order By
Previous Message Atri Sharma 2016-01-18 17:38:25 Re: 2016-01 Commitfest