Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>
Subject: Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Date: 2016-01-08 15:13:31
Message-ID: 20160108151331.GA584390@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Blind attempt at a Cygwin fix
>
> According to
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=brolga&dt=2016-01-08%2014%3A51%3A27
>
> brolga now tries to compile win32security.c, which it evidently was not
> doing before, but the compile blows up; looks like it is missing #include
> calls (which must exist in other places where this code lives ...)

Obviously this wasn't the best idea ever. Andrew suggests on IM to
revert this on Cygwin to just do the "isatty" check as originally.

I'm CC'ing Marco Atzeri, who has done Cygwin work lately. Maybe he can
spend some time getting this port fixed.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-01-08 15:39:02 Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Previous Message Tom Lane 2016-01-08 15:01:26 Re: pgsql: Blind attempt at a Cygwin fix

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-01-08 15:31:10 Re: dblink: add polymorphic functions.
Previous Message Magnus Hagander 2016-01-08 15:11:08 Re: No Issue Tracker - Say it Ain't So!