Re: BUG #13840: pg_dump generates unloadable SQL when third party string type index option is used

From: Kouhei Sutou <kou(at)clear-code(dot)com>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #13840: pg_dump generates unloadable SQL when third party string type index option is used
Date: 2016-01-02 14:43:21
Message-ID: 20160102.234321.2048568850499122365.kou@clear-code.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

In <15194(dot)1451680235(at)sss(dot)pgh(dot)pa(dot)us>
"Re: [BUGS] BUG #13840: pg_dump generates unloadable SQL when third party string type index option is used" on Fri, 01 Jan 2016 15:30:35 -0500,
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>>> pg_dump should generates "normalizer='none'" as option to avoid the
>>> error.
>
>> I attach a patch.
>
> Pushed with some adjustments (notably, I thought the quoting rule was
> too complicated and not necessarily 100% correct).

Thanks for merging my patch and backporting to released
series.

I didn't know quote_identifier() and simple_quote_literal()
functions. I learned from your adjustments.

Thanks,
--
kou

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2016-01-02 17:50:54 Re: BUG #13840: pg_dump generates unloadable SQL when third party string type index option is used
Previous Message Michael Paquier 2016-01-02 12:14:26 Re: BUG #13770: Extending recovery_min_apply_delay on Standby causes it to be unavailable for a while