Re: extend pgbench expressions with functions

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Tomáš Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extend pgbench expressions with functions
Date: 2015-12-17 04:54:14
Message-ID: 20151217045414.GN2618@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:
> On Wed, Dec 16, 2015 at 6:10 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Mon, Dec 14, 2015 at 7:25 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> >> I have looked for now at the first patch and finished with the
> >> attached while looking at it. Perhaps a committer could look already
> >> at that?
> >
> > It looks fine to me except that I think we should spell out "param" as
> > "parameter" throughout, instead of abbreviating.
>
> Fine for me. I have updated the first patch as attached (still looking
> at the second).

hm, so this is to backpatch, not merely for master, yes?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-12-17 04:57:48 Re: extend pgbench expressions with functions
Previous Message Tatsuro Yamada 2015-12-17 04:51:00 A Typo in regress/sql/privileges.sql