Re: PostgresNode::_update_pid using undefined variables in tap tests

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PostgresNode::_update_pid using undefined variables in tap tests
Date: 2015-12-08 23:57:27
Message-ID: 20151208235727.GH2763@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:

> This code should have checked for the return result of open instead of
> looking at $pidfile. This has been noticed by Noah as well afterwards
> and already addressed as 9821492.

Oops, sorry I didn't credit you in the commit message.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-12-08 23:58:30 Re: [PATCH] Equivalence Class Filters
Previous Message Jim Nasby 2015-12-08 23:55:50 Re: [PATCH] Equivalence Class Filters