Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

Noah Misch wrote:

> git checkout 807b9e0
> (find src -name \*.pl -o -name \*.pm ) | sort -u | xargs perltidy --profile=src/tools/pgindent/perltidyrc
>
> perltidy v20090616 leaves the working directory clean, but perltidy v20150815
> introduces diffs:
>
> src/backend/catalog/genbki.pl | 15 ++++++++-------
> src/bin/pg_basebackup/t/010_pg_basebackup.pl | 2 +-
> src/tools/msvc/Install.pm | 6 +++---
> src/tools/msvc/Mkvcbuild.pm | 2 +-
> src/tools/msvc/Project.pm | 2 +-
> src/tools/msvc/Solution.pm | 5 ++---
> src/tools/msvc/gendef.pl | 4 ++--
> 7 files changed, 18 insertions(+), 18 deletions(-)
>
> You see a different result?

Oh, you're right -- on that commit, I get the same results as you with
v20090616 (no changes). I don't have v20150815; the version packaged by
Debian is v20140328, and Install.pm is not changed by that one (so I
only get 15 lines changed, not 18).

I think my confusion stems from code that was introduced after the last
pgindent run. I guess I could have tidied the original files prior to
patching.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services