| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Trivial heap_finish_speculative() error message inaccuracy |
| Date: | 2015-11-18 22:50:30 |
| Message-ID: | 20151118225030.GA5217@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-11-03 19:14:44 -0800, Peter Geoghegan wrote:
> On Tue, Nov 3, 2015 at 7:10 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > This seems like a fine teaching moment in which to point out our
> > longstanding error message style guideline that says not to put
> > names of C functions into error messages in the first place.
>
> I don't ordinarily do that, of course, but I thought it was important
> to be consistent with other such elog() calls within heapam.c.
Internal, super unlikely, elog()s don't seem to need much consistency
among themselves.
> I think that there at least 10 that look like this.
Let's rather rip those function names out. Unless somebody protests I'm
going to do so in 9.5/master.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-11-18 23:29:50 | Re: Using quicksort for every external sort run |
| Previous Message | Tom Lane | 2015-11-18 22:19:43 | Re: Bug in numeric multiplication |