Re: BUG #13764: function ghstore_consistent() returns a wrong value if var "strategy" contains an unsupported number

rucsoftsec(at)163(dot)com wrote:

> function ghstore_consistent() computes the consistency and return a bool
> value. It first computes the value of variable "strategy". It second
> executes different branches of the code depending of different value of
> variable "straregy". When the value of variable"strategy" is an unsupported
> strategy number, function ghstore_consistent() will executes the code in
> line 584. It means function ghstore_consistent() fails, but the value of
> variable "res" is "true" which will be returned in line 586. Therefore, does
> it need to assign "false" to variable "res" after line 584?

No, because elog(ERROR) never returns and so the "return" in
ghstore_consistent() is not reached. It doesn't matter what value "res"
contains.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services