| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, kondo(at)sraoss(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::') |
| Date: | 2015-11-08 22:47:34 |
| Message-ID: | 20151108224734.GB1142850@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Oct 29, 2015 at 05:39:36PM +0900, Tatsuo Ishii wrote:
> > I am happy to finish it, but I am no less happy if you finish it. Which do
> > you prefer?
>
> Please go ahead and commit.
>
> > Should the back-branch commits mirror the master branch? A more-cautious
> > alternative would be to, in back branches, wrap the change in #ifdefs so it
> > takes effect only on Windows, OpenBSD and NetBSD. It could break setups with
> > local firewall rules that block connections to "127.0.0.1" or "::1" without
> > blocking "0.0.0.0" or "::". Such firewall rules sound outlandish enough that
> > I would be fairly comfortable not worrying about this and making the change
> > unconditional in all branches. It's a judgment call, though.
>
> I think back patching with #ifdefs is better. On Windows etc. the case
> has been broken anyway and the fix should only bring benefits to users.
I committed it with #ifdef in 9.1-9.4 and without #ifdef in 9.5 and master.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | sumit_ghosh | 2015-11-09 04:29:10 | BUG #13759: Getting error while installing through Stackbuilder 3.1.1 |
| Previous Message | Michael Paquier | 2015-11-08 12:50:35 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-11-08 23:04:40 | Re: PATCH: 9.5 replication origins fix for logical decoding |
| Previous Message | Tom Lane | 2015-11-08 22:24:21 | Re: Uh-oh: documentation PDF output no longer builds in HEAD |