| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql completion for ids in multibyte string |
| Date: | 2015-11-06 02:47:17 |
| Message-ID: | 20151106.114717.170526268.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi. Thank you for the comments.
The revised version is attaced.
- A typo is fixed in the comment for PQmblen().
- Do the same fix to PQdsplen().
At Thu, 5 Nov 2015 18:32:59 +0900, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote in <563B224B(dot)3020400(at)lab(dot)ntt(dot)co(dot)jp>
> On 2015/11/05 18:10, Kyotaro HORIGUCHI wrote:
> > Hello. I don't know whether this is a bug fix or improvement,
>
> Would it be 50-50? :-)
Yeah, honestly saying, I doubt that this is valuable but feel
uneasy to see some of the candidates vanish as completon proceeds
for no persuasive reason.
> In the following change,
>
> - * returns the byte length of the word beginning s, using the
> - * specified encoding.
> + * returns the byte length of the character beginning s, using the specified
> + * encoding.
>
>
> Just a minor nitpick -
>
> ... character beginning *at* s ...?
>
> If so, there would be one more instance to fix.
I think so. I overlooked both of them. And as you mention,
PQdsplen has the same kind of typo. It returns display length of
the *character* beginning *at* s, too.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-identifier-completion-of-multibyte-characters-v2.patch | text/x-patch | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Wagner | 2015-11-06 03:14:25 | Re: patch for geqo tweaks |
| Previous Message | Kyotaro HORIGUCHI | 2015-11-06 02:27:13 | Re: Some bugs in psql_complete of psql |