| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: quieting DEBUG3 |
| Date: | 2015-10-28 19:10:23 |
| Message-ID: | 20151028191023.GA5726@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> Another point I want to reiterate - because nobody seems to be
> addressing it - is that some of these messages are totally useless. I
> grant that printing the transaction state (XIDs, CIDs, etc.) is
> useful. But does anybody really think that it's useful for every
> statement to *additionally* generate DEBUG: CommitTransactionCommand?
> Who looks at that? What value does it have? We do not print a
> message when any other function that is called for every query is
> entered - why that one?
No, it is useless, let's get rid of it. Maybe it was a useful debugging
tool when postgres.c was being developed, but it's not useful now and
instead very bothersome.
> Whether we adjust the log levels of the messages we have or not, we
> surely ought to get rid of the ones that are useless clutter.
Agreed. I liked your proposal for reduction of transaction state
printout to a single, denser line.
> Can anyone think of a single instance in which that particular message
> has been useful in debugging ... anything?
Not I.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-10-28 20:58:30 | Re: Is there any ordering to the values in guc.c? |
| Previous Message | Muthiah Rajan | 2015-10-28 18:59:43 | Re: Disabling START TRANSACTION for a SuperUser |