Re: BUG #13688: lack of return value in r_mark_regions()

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: rucsoftsec(at)163(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #13688: lack of return value in r_mark_regions()
Date: 2015-10-19 15:35:47
Message-ID: 20151019153547.GL3391@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

rucsoftsec(at)163(dot)com wrote:

> For each execuation result of function r_mark_regions(), it always return 1.
> the related code snippets in r_mark_regions() are as following.
> [...]
> However, in its caller function, the return value of function
> r_mark_regions() should have two possibilities at least. So, there lack of
> return value in r_mark_regions().

We're only consumers of the snowball code; we do not maintain those
files. Have you checked the upstream code?

I notice we haven't updated those files since they were first introduced
in 2007. That can't be right ...

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2015-10-19 15:44:17 Re: BUG #13688: lack of return value in r_mark_regions()
Previous Message Tom Lane 2015-10-19 15:31:38 Re: BUG #13687: bug in row_to_json function with '-infinity' timestamp