| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thom Brown <thom(at)linux(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 9.5: Can't connect with PGSSLMODE=require on Windows |
| Date: | 2015-09-28 21:34:21 |
| Message-ID: | 20150928213421.GC3474@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-09-28 17:28:48 -0400, Tom Lane wrote:
> > What I do find curious is that afaics before 680513ab79 the code also
> > looked at errno, not SOCK_ERRNO. And apparently things worked back then?
>
> No; AFAICS, before that commit, libpq did not use a custom BIO at all.
> That commit cloned the backend's custom BIO, but did not correctly
> adjust the backend's errno handling for the libpq environment.
Oh, yea.
> Will go fix it.
We now probably could remove
* XXX OpenSSL 1.0.1e considers many more errcodes than just EINTR as reasons
* to retry; do we need to adopt their logic for that?
since we now actually check for more tahn just EINTR.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-09-28 21:45:18 | Re: 9.5: Can't connect with PGSSLMODE=require on Windows |
| Previous Message | Tom Lane | 2015-09-28 21:28:48 | Re: 9.5: Can't connect with PGSSLMODE=require on Windows |