| From: | "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de> |
|---|---|
| To: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: [PATCH] Refactoring of LWLock tranches |
| Date: | 2015-09-06 11:36:34 |
| Message-ID: | 20150906113634.GC7137@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2015-09-05 12:48:12 +0300, Ildus Kurbangaliev wrote:
> Another parts require a some discussion so I didn't touch them yet.
At this point I don't see any point in further review until these are
addressed.
> The idea to create an individual tranches for individual LWLocks have
> come from Heikki Linnakangas and I also think that tranche is a good place to keep
> LWLock name.
I think it's rather ugly.
> Base of these tranches points to MainLWLockArray
And that's just plain wrong. The base of a tranche ought to point to the
first lwlock in it.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-09-06 12:08:32 | Re: checkpointer continuous flushing |
| Previous Message | Andres Freund | 2015-09-06 11:32:15 | Re: replication slot restart_lsn initialization |