Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment

On 2015-08-12 16:08:08 -0300, Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> > Close some holes in BRIN page assignment
>
> buildfarm evidently didn't like this one :-(

clang seems to see a (the?) problem:

/home/andres/src/postgresql/src/backend/access/brin/brin_pageops.c:357:6: warning: variable 'extended' is used uninitialized whenever 'if'
condition is false [-Wsometimes-uninitialized]
if (!BufferIsValid(*buffer))
^~~~~~~~~~~~~~~~~~~~~~~
/home/andres/src/postgresql/src/backend/access/brin/brin_pageops.c:371:6: note: uninitialized use occurs here
if (extended)
^~~~~~~~
/home/andres/src/postgresql/src/backend/access/brin/brin_pageops.c:357:2: note: remove the 'if' if its condition is always true
if (!BufferIsValid(*buffer))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/andres/src/postgresql/src/backend/access/brin/brin_pageops.c:330:16: note: initialize the variable 'extended' to silence this warning
bool extended;

Looks to me like it's right. That also explains why it's failing on a
fairly random selection of platforms and compilers...

Andres