Re: [COMMITTERS] Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)

Tom Lane wrote:

> However, we did learn something valuable from the fact that all the
> -DCLOBBER_CACHE_ALWAYS critters failed on it: per my earlier message,
> brin_page_items() is unsafe against a relcache flush on the index.
> I'll put that on the 9.5 open items list.
>
> (If I were tasked with fixing it, I'd be tempted to rewrite it to do
> all the work in one call and return a tuplestore; the alternative
> seems to be to try to keep the index open across multiple calls,
> which would be a mess.)

Here's a patch doing that.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services