Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christoph Berg <myon(at)debian(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Date: 2015-08-10 15:33:05
Message-ID: 20150810153305.GC15799@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2015-08-10 11:19:56 -0400, Tom Lane wrote:
> Meh. I think we'd agreed in another nearby thread that pageinspect
> is exactly the sort of thing we don't want in core.

I think we agreed that it shouldn't be included in an initdb'ed
database, but that doesn't preclude pageinspect being an extension in
src/extension or something.

> Even if it were
> in core, I'm dubious that it's a good way to implement the desired
> testing here: the risks of platform-dependent results (endianness,
> varying numbers of tuples per page, etc etc) seem far too high.

That on the other hand I can agree with being a danger.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-08-10 20:00:40 Re: [COMMITTERS] pgsql: Fix pg_dump to dump shell types.
Previous Message Tom Lane 2015-08-10 15:32:26 Re: pgsql: Temporarily(?) remove BRIN isolation test.

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2015-08-10 15:36:29 Re: WIP: Rework access method interface
Previous Message Tom Lane 2015-08-10 15:31:04 Re: Precedence of standard comparison operators