| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: expose confirmed_flush for replication slots |
| Date: | 2015-08-10 11:29:21 |
| Message-ID: | 20150810112921.GD16192@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-07-08 15:01:15 +0300, Marko Tiikkaja wrote:
> + if (confirmed_flush_lsn != InvalidTransactionId)
> + values[i++] = LSNGetDatum(confirmed_flush_lsn);
> + else
> + nulls[i++] = true;
> +
Hm. That comparison is using the wrong datatype, but it appears you only
copied my earlier mistake... Fixed back to 9.4 and in your patch.
Other notes:
* you missed to touch test_decoding's regression test output files.
* None of the docs were touched. catalogs.sgml definitely needs docs
about the new columns, and I see no reason to leave the examples
elsewhere stale.
Fixed those and committed it. Thanks for the patch!
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-08-10 11:29:30 | Re: Don'st start streaming after creating a slot in pg_receivexlog |
| Previous Message | Christoph Berg | 2015-08-10 11:00:38 | Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization) |