| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Raising our compiler requirements for 9.6 |
| Date: | 2015-08-06 15:29:15 |
| Message-ID: | 20150806152915.GO2441@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> I had to split of three things: LOCKMASK, the individual lock levels and
> xl_standby_lock to be able to prohibit lock.h to be included by frontend
> code. lockdefs.h works for me, counter proposals?
>
> There weren't any places that needed additional lock.h includes.
Ah, but that's because you cheated and didn't remove the include from
namespace.h ...
> But hashfn.c somewhat hilariously missed utils/hsearch.h ;)
hah.
> diff --git a/src/include/storage/lockdefs.h b/src/include/storage/lockdefs.h
> new file mode 100644
> index 0000000..bfbcdba
> --- /dev/null
> +++ b/src/include/storage/lockdefs.h
> @@ -0,0 +1,56 @@
> +/*-------------------------------------------------------------------------
> + *
> + * lockdefs.h
> + * Frontend exposed parts of postgres' low level lock mechanism
> + *
> + * The split between lockdefs.h and lock.h is not very principled.
No kidding!
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-08-06 15:32:34 | Re: deparsing utility commands |
| Previous Message | Jim Nasby | 2015-08-06 15:26:03 | Re: deparsing utility commands |