Re: track_commit_timestamp and COMMIT PREPARED

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: track_commit_timestamp and COMMIT PREPARED
Date: 2015-08-04 17:18:11
Message-ID: 20150804171811.GC32119@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-08-04 13:16:52 -0400, Robert Haas wrote:
> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
> > but not in master server. Is this intentional? It should track COMMIT PREPARED
> > even in master? Otherwise, we cannot use commit_timestamp feature to check
> > the replication lag properly while we use 2PC.
>
> That sounds like it must be a bug. I think you should add it to the
> open items list.

Yea, completely agreed. It's probably because twophase.c duplicates a
good bit of xact.c. How about we also add a warning to the respective
places that one should always check the others?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-08-04 17:20:49 Re: FSM versus GIN pending list bloat
Previous Message Robert Haas 2015-08-04 17:16:52 Re: track_commit_timestamp and COMMIT PREPARED