| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] postgres_fdw extension support |
| Date: | 2015-07-21 15:26:29 |
| Message-ID: | 20150721152629.GK5520@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-07-21 17:00:51 +0200, Andres Freund wrote:
> On 2015-07-21 07:55:17 -0700, Paul Ramsey wrote:
> > On Tue, Jul 21, 2015 at 7:45 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > So, right after reading the options in postgresGetForeignRelSize,
> > expand the extension list into a list of all ops/functions, in a
> > sorted list, and let that carry through to the deparsing instead?
>
> I'd actually try to make it longer lived, i.e. permanently. And just
> deallocate when a catcache callback says it needs to be invalidated;
> IIRC there is a relevant cache.
On second thought I'd not use a binary search but a hash table. If you
choose the right key a single table is enough for the lookup.
If you need references for invalidations you might want to look for
CacheRegisterSyscacheCallback callers. E.g. attoptcache.c
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2015-07-21 15:38:43 | Re: Selectivity estimation for intarray with @@ |
| Previous Message | Petr Jelinek | 2015-07-21 15:02:52 | Re: TABLESAMPLE patch is really in pretty sad shape |