Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22
Date: 2015-07-12 22:05:28
Message-ID: 20150712220528.GA1103701@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-announce pgsql-hackers

On Sun, Jul 12, 2015 at 05:02:51PM -0400, Andrew Dunstan wrote:
> >>Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com> writes:
> >>>for what I see the hstore_plperl link has a double problem.
> >>>It requires a link to hstore
> >>>as it also requires a link to perl.
> >>>Attached patch for solving this and a similar issue with python.
> >>>+ifeq ($(PORTNAME), cygwin)
> >>>+# This means we need an in-tree build on Windows, not a pgxs build
> >>>+SHLIB_LINK += -L../hstore -lhstore -L$(perl_archlibexp)/CORE -lperl
> >>>+endif

That's the right general strategy, agreed.

> Unless there is further argument I propose to commit something very like
> Marco's suggestion for hstore_plperl, hstore_plpython and ltree_plpython

Would you post the final patch for review?

Thanks,
nm

In response to

Browse pgsql-announce by date

  From Date Subject
Next Message David Fetter 2015-07-12 23:22:59 == PostgreSQL Weekly News - July 12 2015 ==
Previous Message Tom Lane 2015-07-12 21:06:33 Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2015-07-12 22:26:41 Re: creating extension including dependencies
Previous Message Peter Geoghegan 2015-07-12 21:41:21 Re: Free indexed_tlist memory explicitly within set_plan_refs()