Re: pgsql: Add assign_expr_collations() to CreatePolicy() and AlterPolicy()

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add assign_expr_collations() to CreatePolicy() and AlterPolicy()
Date: 2015-07-12 03:21:38
Message-ID: 20150712032138.GA30572@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Jul 11, 2015 at 09:20:41PM +0000, Joe Conway wrote:
> Add assign_expr_collations() to CreatePolicy() and AlterPolicy().
>
> As noted by Noah Misch, CreatePolicy() and AlterPolicy() omit to call
> assign_expr_collations() on the node trees. Fix the omission and add
> his test case to the rowsecurity regression test.

I think this commit has added a compiler warning:

policy.c:542: warning: implicit declaration of function 'assign_expr_collations'

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-07-12 03:35:16 pgsql: Add now-required #include.
Previous Message Bruce Momjian 2015-07-12 02:46:37 pgsql: doc: fix typo in CREATE POLICY manual page