| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Set of patch to address several Coverity issues |
| Date: | 2015-07-09 14:08:52 |
| Message-ID: | 20150709140852.GA10242@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-07-09 22:57:25 +0900, Michael Paquier wrote:
> On Wed, Jul 8, 2015 at 6:16 PM, Andres Freund wrote:
> >> In any case, we are going to need at least (void) in front of those calls.
> >
> > We're "needing" nothing of the sort.
>
> I don't really understand your reluctance here. As one example, see
> c831593 where similar fixes are done and even back-patched.
That doesn't make it a required thing. And the changes there we more
than just adding a (void).
To me this kind of changes are busywork. Analsys tools are there to make
our work easier, not to generate more. There's good reasons why, with
other tools, in the past we've rejected lots of bogus "issues", even if
we could have silenced them by changing the code.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2015-07-09 14:18:06 | Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement |
| Previous Message | Michael Paquier | 2015-07-09 13:57:25 | Re: Set of patch to address several Coverity issues |