Re: Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

From: Andres Freund <andres(at)anarazel(dot)de>
To: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Subject: Re: Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement
Date: 2015-07-09 13:56:21
Message-ID: 20150709135621.GZ10242@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-07-09 10:39:35 -0300, Fabrízio de Royes Mello wrote:
> If the "wal_level=minimal" we don't need to force the wal log of the
> contents. If the "wal_level != minimal" we need just to xlog all the pages,
> but in both cases we don't need the extra job to create a new datafiles and
> copy the contents between them. So we'll improve performance, or am I
> missing something?

Sure. It'll be a bit faster. I just don't see the peformance increase in
not that common situations being worth the price we'll pay in
development, code review, debugging and then maintaining some nontrivial
code. If this were likely to be a 15 line patch, I'd think differently.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-07-09 13:57:25 Re: Set of patch to address several Coverity issues
Previous Message Michael Paquier 2015-07-09 13:55:01 Re: Supporting TAP tests with MSVC and Windows