Re: less log level for success dynamic background workers for 9.5

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: less log level for success dynamic background workers for 9.5
Date: 2015-06-23 16:50:19
Message-ID: 20150623165019.GA3289@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Tue, Jun 23, 2015 at 10:53 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> > 2015-06-23 15:20 GMT+02:00 Robert Haas <robertmhaas(at)gmail(dot)com>:
> >> I was thinking of a background worker flag, not a GUC.
> >> BGWORKER_QUIET, or something like that. But I guess we ought to just
> >> change it.
> >
> > I have not any problem with bg worker flag. The only question is, what
> > should be by default.
>
> Well, if the flag is BGWORKER_QUIET, then the default behavior remains
> unchanged, but when that flag is used, the log level is reduced to
> DEBUG1. That has the advantage of not breaking backward
> compatibility. But I'm not sure whether anyone cares if we just break
> it, and it's certainly simpler without the flag.

I vote we do it the other way around, that is have a flag BGWORKER_VERBOSE.
This breaks backwards compatibility (I don't think there's too much
value in that in this case), but it copes with the more common use case
that you want to have the flag while the worker is being developed; and
things that are already working don't need to change in order to get the
natural behavior.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-06-23 17:21:44 Re: less log level for success dynamic background workers for 9.5
Previous Message Tom Lane 2015-06-23 16:42:11 Re: NULL passed as an argument to memcmp() in parse_func.c