Re: Collection of memory leaks for ECPG driver

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: Collection of memory leaks for ECPG driver
Date: 2015-06-13 09:25:13
Message-ID: 20150613092513.GB14175@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 13, 2015 at 12:02:40AM -0400, Tom Lane wrote:
> But having said that, I would not be in a hurry to remove any existing
> if-guards for the case. For one thing, it makes the code look more
> similar to backend code that uses palloc/pfree, where we do *not* allow
> pfree(NULL). There's also the point that changing longstanding code
> creates back-patching hazards, so unless there's a clear gain it's best
> not to.

Makes sense, but there is no point in adding hos if-guards to old code that
doesn't have it either,right?

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message deavid 2015-06-13 09:41:14 Re: Is it possible to have a "fast-write" Index?
Previous Message Alvaro Herrera 2015-06-13 08:47:59 Re: 9.5 release notes