Re: reaper should restart archiver even on standby

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reaper should restart archiver even on standby
Date: 2015-06-10 16:39:05
Message-ID: 20150610163905.GZ133018@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:

> Agreed. The attached patch defines the macro to check whether archiver is
> allowed to start up or not, and uses it everywhere except sigusr1_handler.
> I made sigusr1_handler use a different condition because only it tries to
> start archiver in PM_STARTUP postmaster state and it looks a bit messy
> to add the check of that state into the centralized check condition.

WFM, but do these macros in xlog.h need a one-line comment to state
their purpose?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-06-10 16:51:35 pg_rewind failure by file deletion in source server
Previous Message Gurjeet Singh 2015-06-10 16:10:50 Re: replication slot restart_lsn initialization