| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, tomas(dot)vondra(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) |
| Date: | 2015-06-08 03:42:49 |
| Message-ID: | 20150608034249.GA7146@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
This is a followup to a 2014-02 discussion that led to pg_stats_temp
being excluded from pg_basebackup. At the time, it was discussed to
exclude pg_log as well, but nothing eventually came of that.
Recently, one of our customers has had a basebackup fail because pg_log
contained files that were >8GB:
FATAL: archive member "pg_log/postgresql-20150119.log" too large for tar format
I think pg_basebackup should also skip pg_log entries, as it does for
pg_stats_temp and pg_replslot, etc. I've attached a patch along those
lines for discussion.
-- Abhijit
P.S. Aren't we leaking statrelpath?
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Skip-files-in-pg_log-during-basebackup.patch | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-06-08 03:56:47 | Re: pg_stat_archiver issue with aborted archiver |
| Previous Message | Michael Paquier | 2015-06-08 02:52:38 | Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial) |