Re: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.
Date: 2015-05-29 21:49:27
Message-ID: 20150529214927.GA6535@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2015-05-29 19:11:58 +0000, Tom Lane wrote:
> Andres had brought it up back when we were
> still considering that most fsync failures should be hard errors, and it
> probably would be legit not to fail hard for ETXTBSY --- but the same is
> true for EROFS and other cases, which is why we gave up on hard failures.
> ETXTBSY is surely not a normal case, so logging the failure seems fine
> from here.

Note that EROFS etc should never happen without following symlinks,
whereas ETXTBSY conceivably could.

I'm fine though, with the special case being removed, I think you made a
good point that it's unlikely that e.g. an archive_command will run
during startup.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-05-30 02:14:52 Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Previous Message Bruce Momjian 2015-05-29 21:44:59 pgsql: pg_upgrade: add missing period in C comment