Re: fsync-pgdata-on-recovery tries to write to more files than previously

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: fsync-pgdata-on-recovery tries to write to more files than previously
Date: 2015-05-28 17:19:48
Message-ID: 20150528171948.GA24354@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2015-05-28 19:56:15 +0530, ams(at)2ndQuadrant(dot)com wrote:
>
> I have a separate patch to initdb with the corresponding changes, which
> I will post after dinner and a bit more testing.

Here's that patch too.

I was a bit unsure how far to go with this. It fixes the problem of not
following pg_xlog if it's a symlink (Andres) and the one where it died
on bogus stuff in pg_tblspc (Tom) and unreadable files anywhere else
(it now spews errors to stderr, but carries on for as long as it can).

I've done a bit more than strictly necessary to fix those problems,
though, and made the code largely similar to what's in the other patch.
If you want something minimal, let me know and I'll cut it down to size.

-- Abhijit

P.S. If this patch gets applied, then the "Adapted from walktblspc_links
in initdb.c" comment in fd.c should be changed: s/links/entries/.

Attachment Content-Type Size
0001-20150528-Make-initdb-S-behave-like-xlog.c-fsync_pgdata.patch text/x-diff 11.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-05-28 17:29:46 Re: fsync-pgdata-on-recovery tries to write to more files than previously
Previous Message Josh Berkus 2015-05-28 17:10:19 Re: About that re-release ...