| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Run pgindent now? |
| Date: | 2015-05-27 15:53:59 |
| Message-ID: | 20150527155359.GA31835@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 27, 2015 at 02:31:07AM +0200, Andres Freund wrote:
> But really, the typedef list is the minor part what annoys me about
> pgindent. That it completely butchers so many constructs (e.g. function
> pointer typedefs, inline asm as extreme examples) is much worse. It's
> also neigh on impossible to predict/keep the indentation pgindent will
> use in many cases. Having to try to write code in a way that doesn't
> break the re-indentation tool, even if it'd otherwise be fine, is just
> absurd.
What does "break" mean here? Considering we are indenting 1.4M lines of
code, skipping ASM files seems pretty minor.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dan Langille | 2015-05-27 16:00:16 | PGCon hacker lounge |
| Previous Message | Christoph Berg | 2015-05-27 15:40:09 | pg_upgrade resets timeline to 1 |