Re: Run pgindent now?

On Mon, May 25, 2015 at 03:20:47PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Mon, May 25, 2015 at 03:12:24PM -0400, Tom Lane wrote:
> >> The point is for the back branches to absorb pgindent-induced changes that
> >> have already happened in HEAD, so I'm not sure what you're getting at.
>
> > My point is uses of new typedefs names added in HEAD which are not
> > typedefs in the back branches will be pgindent'ed differently than
> > before, e.g. back branches use a variable 'aaa' which is not a typedef
> > in back branches, but if 'aaa' becomes a typedef in HEAD, references to
> > 'aaa' in back branches will be adjusted by pgindent.
>
> Right, and that's what we want, because the corresponding uses of 'aaa'
> as a variable will also have been changed in HEAD. The point of this
> exercise is to ensure that otherwise-equivalent code is indented the same
> in all branches.

OK, makes sense. You can see the old and 'all' diffs here:

http://momjian.us/expire/

The diff size went from 5.7k to 5.3k lines.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +